Merged
Conversation
6 tasks
cwfitzgerald
previously requested changes
Jan 28, 2024
Member
cwfitzgerald
left a comment
There was a problem hiding this comment.
Howdy! wgpu test fairy here: could you add execution tests for this in wgpu. We need at least one test, but there could be other things:
- struct layout should be tested in struct_layout.rs
JMS55
reviewed
Feb 17, 2024
This was referenced Feb 19, 2024
Merged
teoxoy
reviewed
Mar 4, 2024
teoxoy
reviewed
Mar 4, 2024
teoxoy
reviewed
Mar 4, 2024
Member
|
This needs a rebase or another merge of trunk into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Part of an incoming series of PRs needed by #5123
Others in this series: #5155
Addresses #4424
Ultimately for bevy meshlets pipeline bevyengine/bevy#10164
Description
Shaders currently do not support 64 bit integer types. Add support for these gated by a feature flag when the capability is present.
Testing
A snapshot test called i64.wgsl has been added to test parsing, type casting, and other basic operations.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.