Merged
Conversation
Member
|
I think the old names were good when there was only on/off option. With more options, we need better names, and your suggestion sounds fine by me, but only under one condition: if the implementation is able to silently fall back if |
Contributor
Author
|
It falls back to FIFO if not supported: wgpu/wgpu-core/src/device/mod.rs Lines 1833 to 1840 in 584c9d7 |
Contributor
Build succeeded |
Merged
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
512: Convert to using independent subscriber implementation r=kvark a=cwfitzgerald gfx-rs#881 but for wgpu-rs. Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kvark
Would you be open to renaming the presents modes to match the vulkan/gfx-hal nomenclature? Considering these aren't part of the webgpu spec, I think it would make more sense to keep things consistent.
I can update this PR if you're good with it.