Closed
Conversation
Set public the `ComputeCommand`, `PhantomSlice` and some underlying functions.
ff9ef4d to
079da18
Compare
3 tasks
kvark
reviewed
Feb 18, 2020
Member
kvark
left a comment
There was a problem hiding this comment.
Do we really need to use this directly? wgpu-core exposes a bunch of easy to use C functions that can be used to encode passes.
Author
|
Thank you for pointing that out! We can definitely use the exposed C functions, as you mentioned. So I'm closing this pull request. |
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
496: Replace u32 with NonZeroU32 in TextureView r=kvark a=kunalmohan Includes gfx-rs#865 Co-authored-by: Kunal Mohan <kunalmohan99@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set public the
ComputeCommand,PhantomSliceand some underlying functions.