[wgpu] correct doc for resolve query set#4849
Merged
Wumpf merged 3 commits intogfx-rs:trunkfrom Dec 9, 2023
valaphee:resolve-query-set-doc
Merged
[wgpu] correct doc for resolve query set#4849Wumpf merged 3 commits intogfx-rs:trunkfrom valaphee:resolve-query-set-doc
Wumpf merged 3 commits intogfx-rs:trunkfrom
valaphee:resolve-query-set-doc
Conversation
Member
|
CI is failing |
Member
|
oops, my fault! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Closes #4838
Description
Moved
resolve_query_setto the general command encoder impl, as it technically doesn't require any feature, is not meaningful to the end user, and it's not possible to create a query set with an unsupported type anyway.And added info about how many bytes to expect.
Testing
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.