Skip to content

Incorrect docs for resolve_query_set #4838

@kpreid

Description

@kpreid

I was reading about occlusion culling and looking at the wgpu documentation for relevant features, and noticed something odd in the docs for CommandEncoder::resolve_query_set() and its impl (source).

  • The function documentation says "See PipelineStatisticsTypes for more information." Surely this should be QueryType?
  • The impl block documentation says “Features::TIMESTAMP_QUERY or Features::PIPELINE_STATISTICS_QUERY must be enabled on the device in order to call these functions.” But occlusion queries are neither of those, and there's only one function in the impl block.

I suspect these are both left over from a previous WebGPU API revision, but I have no experience with queries so I can't be confident that I'm right or what the correct statement is. Happy to send a PR if the intent can be clarified.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions