-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Incorrect docs for resolve_query_set #4838
Copy link
Copy link
Closed
Description
I was reading about occlusion culling and looking at the wgpu documentation for relevant features, and noticed something odd in the docs for CommandEncoder::resolve_query_set() and its impl (source).
- The function documentation says "See
PipelineStatisticsTypesfor more information." Surely this should beQueryType? - The
implblock documentation says “Features::TIMESTAMP_QUERYorFeatures::PIPELINE_STATISTICS_QUERYmust be enabled on the device in order to call these functions.” But occlusion queries are neither of those, and there's only one function in theimplblock.
I suspect these are both left over from a previous WebGPU API revision, but I have no experience with queries so I can't be confident that I'm right or what the correct statement is. Happy to send a PR if the intent can be clarified.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels