Update multi-planar texture API#4837
Merged
cwfitzgerald merged 1 commit intogfx-rs:trunkfrom Dec 7, 2023
Merged
Conversation
nical
approved these changes
Dec 6, 2023
1ef6fd4 to
57f6cd6
Compare
cwfitzgerald
requested changes
Dec 6, 2023
Member
cwfitzgerald
left a comment
There was a problem hiding this comment.
Some small stuff, but looks much better
65f57c6 to
4b61126
Compare
xiaopengli89
reviewed
Dec 7, 2023
- remove the need to pass the plane formats to `view_formats` - move plane selection in `TextureAspect`
cwfitzgerald
approved these changes
Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
#4825 & #4823 (comment)
Description
view_formatsTextureAspectcc @xiaopengli89