[wgsl-in] add support for override declarations#4793
Merged
jimblandy merged 3 commits intogfx-rs:pipeline-constantsfrom Dec 7, 2023
Merged
[wgsl-in] add support for override declarations#4793jimblandy merged 3 commits intogfx-rs:pipeline-constantsfrom
jimblandy merged 3 commits intogfx-rs:pipeline-constantsfrom
Conversation
5295d13 to
80b23c1
Compare
[ir] split overrides from constants
80b23c1 to
587b62d
Compare
jimblandy
approved these changes
Dec 7, 2023
Member
jimblandy
left a comment
There was a problem hiding this comment.
The compaction can be simplified, and I think one of the tests should be tweaked slightly, but otherwise this looks great. I'll make the changes myself.
Member
There was a problem hiding this comment.
We also need a test like this:
override inferred_f32 = 3.1415;
When we merge this branch with the abstract type changes, we will need to make sure that lowering uses the concretized initializer value to infer the override's type, not its value in isolation. I think this test will catch that case, so we'll know to fix it when the merge happens.
Also, let's give this file a final newline.
teoxoy
added a commit
that referenced
this pull request
Jan 8, 2024
Co-authored-by: Jim Blandy <jimb@red-bean.com>
teoxoy
added a commit
that referenced
this pull request
Jan 8, 2024
Co-authored-by: Jim Blandy <jimb@red-bean.com>
teoxoy
added a commit
that referenced
this pull request
Feb 12, 2024
Co-authored-by: Jim Blandy <jimb@red-bean.com>
teoxoy
added a commit
that referenced
this pull request
Feb 12, 2024
Co-authored-by: Jim Blandy <jimb@red-bean.com>
teoxoy
added a commit
that referenced
this pull request
Feb 12, 2024
Co-authored-by: Jim Blandy <jimb@red-bean.com>
teoxoy
added a commit
that referenced
this pull request
Mar 14, 2024
Co-authored-by: Jim Blandy <jimb@red-bean.com>
teoxoy
added a commit
that referenced
this pull request
Apr 4, 2024
Co-authored-by: Jim Blandy <jimb@red-bean.com>
teoxoy
added a commit
that referenced
this pull request
Apr 4, 2024
Co-authored-by: Jim Blandy <jimb@red-bean.com>
Merged
teoxoy
added a commit
that referenced
this pull request
Apr 5, 2024
Co-authored-by: Jim Blandy <jimb@red-bean.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for override declarations and splits overrides from constants in the IR.
Tracking meta issue: #4484.