Don't drop command buffers when submitting in wgpu_core#4660
Merged
nical merged 1 commit intogfx-rs:trunkfrom Nov 9, 2023
nical:cmdbuf-destroy
Merged
Don't drop command buffers when submitting in wgpu_core#4660nical merged 1 commit intogfx-rs:trunkfrom nical:cmdbuf-destroy
nical merged 1 commit intogfx-rs:trunkfrom
nical:cmdbuf-destroy
Conversation
Since wgpu's submit API consumes command buffers, they are dropped when submitting via wgpu but not when when using wgpu_core.
ErichDonGubler
approved these changes
Nov 9, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since wgpu's submit API consumes command buffers, they are dropped when submitting via wgpu but not when when using wgpu_core.
Checklist
cargo clippy.Connections
Addresses #4659, unblocks https://phabricator.services.mozilla.com/D192839
Description
With WebGPU it is possible for a submitted command buffer to appear inother API entry point. This should cause validation errors but currently it panics because submit unregisters the command buffers. This PR makes it so command buffers are not dropped at the wgpu core level when submitting (they are dropped at the wgpu level to avoid changing the API).
Testing
This is covered by the CTS in firefox and for the wgpu behavior, it is exercised by a number of the existing tests.