Paths

Table of Contentst

Differential D192839

Bug 1861985 - Let the parent process handle validating command encoders. r=#webgpu-reviewers
ClosedPublic
Actions

Authored by nical on Nov 6 2023, 1:34 PM.

Tags

Referenced Files

	Unknown Object (File)
	Fri, Apr 17, 11:04 AM

	Unknown Object (File)
	Mon, Apr 13, 2:29 AM

	Unknown Object (File)
	Thu, Apr 9, 3:56 PM

	Unknown Object (File)
	Wed, Apr 8, 6:37 AM

	Unknown Object (File)
	Tue, Apr 7, 3:32 PM

	Unknown Object (File)
	Tue, Apr 7, 12:53 PM

	Unknown Object (File)
	Tue, Apr 7, 11:16 AM

	Unknown Object (File)
	Mon, Apr 6, 4:48 PM

View All 60 Files

Subscribers

Details

Reviewers

saschanaz
jimb

Group Reviewers

webgpu-reviewers
webidl

Commits

rMOZILLACENTRAL655dc5c5782a: Bug 1861985 - Let the parent process handle validating command encoders.
rMOZILLACENTRALe3f53b794c1d: Bug 1861985 - Let the parent process handle validating command encoders.
rMOZILLACENTRAL0bdc4c60018e: Bug 1861985 - Let the parent process handle validating command encoders.

Bugzilla Bug ID

Summary

This makes sure we never create an invalid (zero) ID after incorrect usage of a command encoder.
It also simplifies the code. The JS object should not do any validaion (per spec) and simply forward the commands to the parent process where all of the validation is done.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Build Status

Buildable 599681
Build 697813: arc lint + arc unit

Event Timeline

nical created this revision.Nov 6 2023, 1:34 PM

Herald added a project: secure-revision. · View Herald TranscriptNov 6 2023, 1:34 PM

Harbormaster completed remote builds in B594269: Diff 783763.Nov 6 2023, 1:34 PM

phab-bot published this revision for review.Nov 6 2023, 1:35 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a reviewer: webidl. · View Herald TranscriptNov 6 2023, 1:35 PM

nical mentioned this in D192766: Bug 1861985: Allow CommandBuffers to be constructed with id 0, plus a test..Nov 6 2023, 1:37 PM

Credit goes to Brad Werth for diagnosing the issue and adding the test.

r+ for webidl, just removes [Throws].

This revision is now accepted and ready to land.Nov 6 2023, 2:41 PM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

I hope the herald rule can automatically convert other reviewers into blocking reviewers.

This revision now requires review to proceed.Nov 6 2023, 2:42 PM

jimb accepted this revision.Nov 7 2023, 5:36 PM

jimb edited projects, added testing-approved; removed needs-testing-tag.

This revision is now accepted and ready to land.Nov 7 2023, 5:36 PM

nical added a child revision: D193313: Bug 1861985 - Handle CommandBuffer/CommandBuffer lifecycle correctly. r=#webgpu-reviewers.Nov 13 2023, 5:47 PM

nical updated this revision to Diff 788518.Nov 20 2023, 11:10 AM

Harbormaster completed remote builds in B598254: Diff 788518.Nov 20 2023, 11:10 AM

nical updated this revision to Diff 789391.Nov 21 2023, 5:04 PM

Harbormaster completed remote builds in B598968: Diff 789391.Nov 21 2023, 5:04 PM

nical added a parent revision: D192080: Bug 1860958 - Implement Texture::Destroy. r=#webgpu-reviewers.Nov 21 2023, 5:57 PM

Closed by commit rMOZILLACENTRAL0bdc4c60018e: Bug 1861985 - Let the parent process handle validating command encoders. (authored by bradwerth). · Explain WhyNov 21 2023, 6:22 PM

This revision was automatically updated to reflect the committed changes.

bradwerth added a commit: rMOZILLACENTRAL0bdc4c60018e: Bug 1861985 - Let the parent process handle validating command encoders..

ctuns reopened this revision.Nov 21 2023, 7:13 PM

This revision is now accepted and ready to land.Nov 21 2023, 7:13 PM

ctuns added a reverting change: rMOZILLACENTRAL4fbc2295716f: Backed out 3 changesets (bug 1861985, bug 1860958) for causing build bustages….Nov 21 2023, 7:13 PM

nical updated this revision to Diff 789800.Nov 22 2023, 10:17 AM

Harbormaster completed remote builds in B599344: Diff 789800.Nov 22 2023, 10:17 AM

nical updated this revision to Diff 789820.Nov 22 2023, 10:50 AM

Harbormaster completed remote builds in B599357: Diff 789820.Nov 22 2023, 10:50 AM

Closed by commit rMOZILLACENTRALe3f53b794c1d: Bug 1861985 - Let the parent process handle validating command encoders. (authored by bradwerth). · Explain WhyNov 22 2023, 11:04 AM

This revision was automatically updated to reflect the committed changes.

bradwerth added a commit: rMOZILLACENTRALe3f53b794c1d: Bug 1861985 - Let the parent process handle validating command encoders..

• nataliaCs reopened this revision.Nov 22 2023, 12:12 PM

This revision is now accepted and ready to land.Nov 22 2023, 12:12 PM

• nataliaCs added a reverting change: rMOZILLACENTRALfd0423fbfca0: Backed out 4 changesets (bug 1861985, bug 1860958, bug 1865364) for causing….Nov 22 2023, 12:12 PM

Closed by commit rMOZILLACENTRAL655dc5c5782a: Bug 1861985 - Let the parent process handle validating command encoders. (authored by bradwerth). · Explain WhyNov 22 2023, 3:11 PM

This revision was automatically updated to reflect the committed changes.

bradwerth added a commit: rMOZILLACENTRAL655dc5c5782a: Bug 1861985 - Let the parent process handle validating command encoders..

Harbormaster completed remote builds in B599681: Diff 789947.Nov 23 2023, 6:59 PM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

dom/

webgpu/

CommandEncoder.h

4 lines

33%

Loading...

CommandEncoder.cpp

147 lines

50%

Loading...

ComputePassEncoder.h

2 lines

33%

Loading...

ComputePassEncoder.cpp

4 lines

35%

Loading...

RenderPassEncoder.h

2 lines

33%

Loading...

RenderPassEncoder.cpp

4 lines

33%

Loading...

ipc/

WebGPUChild.cpp

15 lines

32%

Loading...

mochitest/

5 lines

-

-

test_double_encoder_finish.html

36 lines

-

-

webidl/

2 lines

-

-

Diff 789947

dom/webgpu/CommandEncoder.h

Loading...

dom/webgpu/CommandEncoder.cpp

Loading...

dom/webgpu/ComputePassEncoder.h

Loading...

dom/webgpu/ComputePassEncoder.cpp

Loading...

dom/webgpu/RenderPassEncoder.h

Loading...

dom/webgpu/RenderPassEncoder.cpp

Loading...

dom/webgpu/ipc/WebGPUChild.cpp

Loading...

dom/webgpu/mochitest/mochitest.toml

Loading...

dom/webgpu/mochitest/test_double_encoder_finish.html

Loading...

dom/webidl/WebGPU.webidl

Loading...