Skip to content

Remote buffer destruction#396

Merged
bors[bot] merged 1 commit intogfx-rs:masterfrom
kvark:gecko-buf-destroy
Dec 3, 2019
Merged

Remote buffer destruction#396
bors[bot] merged 1 commit intogfx-rs:masterfrom
kvark:gecko-buf-destroy

Conversation

@kvark
Copy link
Copy Markdown
Member

@kvark kvark commented Dec 3, 2019

No description provided.

@kvark
Copy link
Copy Markdown
Member Author

kvark commented Dec 3, 2019

Also re-adds wgpu-remote building to Makefile (see #388). We are still unable to build the remote example though.
merging as trivial
bors r+

bors bot added a commit that referenced this pull request Dec 3, 2019
396: Remote buffer destruction r=kvark a=kvark



Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors
Copy link
Copy Markdown
Contributor

bors bot commented Dec 3, 2019

Build succeeded

@bors bors bot merged commit 486b1b6 into gfx-rs:master Dec 3, 2019
@kvark kvark deleted the gecko-buf-destroy branch December 3, 2019 15:37
kvark added a commit to kvark/wgpu that referenced this pull request Jun 3, 2021
396: Update wgpu without peek-poke r=cwfitzgerald a=kvark

Depends on gfx-rs#739
Everything works, however I think it's worth changing the render pass color/depth/stencil descriptors to be more rusty, e.g.
```rust
struct ColorAttachmentDescriptor {
  attachment: &'a TextureView,
  resolve_target: Option<&'a TextureView>,
  clear_color: Option<Color>,
  store_result: bool,
}

enum DepthStencilChannel<T> {
  ReadOnly,
  Mutable { clear_value: Option<T>, store_result: bool },
}
struct DepthStencilAttachmentDescriptor {
}
```
This would also involve wgpu-type/wgpu-core changes, but can be done as a follow-up (don't want to block on them).

There is a value in doing it in this PR, so that end users don't get multiple disruptions, but we need to find a proper shape first.

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant