Merged
Conversation
grovesNL
approved these changes
Nov 16, 2019
Collaborator
grovesNL
left a comment
There was a problem hiding this comment.
Looks good to me 👍 This gives us a good path forward for sharing the types too
Member
Author
|
Thank you!
Bors r=grovesNL
… On Nov 16, 2019, at 09:40, Josh Groves ***@***.***> wrote:
@grovesNL approved this pull request.
Looks good to me 👍 This gives us a good path forward for sharing the types too
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
bors bot
added a commit
that referenced
this pull request
Nov 16, 2019
381: Separate Native from the Core r=grovesNL a=kvark Fixes #379 (haven't figured out how to build remote static lib to test the example, but that's not as important at this stage, since we have Gecko). Fixes #168 Related to #2 and #8 This is a major refactor that moves out the core Rust API into a separate crate. It also changes the export semantics of wgpu-core in a way that the modules are exposed, and all the functionality is now represented as methods of `Global`. The "local" feature is transformed into a type system as a generic parameter `<F>` on the hubs. Pros: - "local" feature is gone - we can change the core API more often, this doesn't necessarily require the `native` breaking version bump, and it would be very handy when adding Gecko-related changes - Gecko needs less stuff to compile (remote + core) - no collision of library names (native with or without the local feature) - less problem with crate types - cleaner semantics: each crate is either C or Rust, but not both Cons: - more generics, I wouldn't be surprised this regresses the build times visibly Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Contributor
Build succeeded |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #379 (haven't figured out how to build remote static lib to test the example, but that's not as important at this stage, since we have Gecko).
Fixes #168
Related to #2 and #8
This is a major refactor that moves out the core Rust API into a separate crate. It also changes the export semantics of wgpu-core in a way that the modules are exposed, and all the functionality is now represented as methods of
Global. The "local" feature is transformed into a type system as a generic parameter<F>on the hubs.Pros:
nativebreaking version bump, and it would be very handy when adding Gecko-related changesCons: