Fix macro to allow disabling dx12 feature.#3590
Merged
teoxoy merged 3 commits intogfx-rs:masterfrom Mar 15, 2023
Merged
Conversation
Contributor
Author
|
I was able to compile and use wgpu without dx12 using these changes but I realize I should probably add this conditional macro over the |
teoxoy
requested changes
Mar 15, 2023
Member
teoxoy
left a comment
There was a problem hiding this comment.
Thank you for the PR!
Just a nit: we seem to be using the style of guard that I suggested everywhere else.
teoxoy
approved these changes
Mar 15, 2023
toastmod
added a commit
to toastmod/wgpu
that referenced
this pull request
Apr 20, 2023
* Fix macro for DX12 conditional compilation * Update CHANGELOG.md * Apply suggestions from code review --------- Co-authored-by: Teodor Tanasoaia <28601907+teoxoy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
N/A
Description
Couldn't compile when disabling
dx12feature from core inwgpu/Cargo.toml. Fixed by adding:#[cfg(all(target_os = "windows", feature = "dx12"))]My only concerns are if the functions I affected are also supposed to be used with
dx11? Also might need some guidance on fixing the docs deployment test (if that was my fault).Testing
Compiled without
dx12feature inwgpu/Cargo.toml