Merged
Conversation
429c829 to
fe89c52
Compare
grovesNL
approved these changes
Sep 9, 2019
|
|
||
| #[derive(Debug, Default)] | ||
| pub struct Hubs { | ||
| #[cfg(any(not(any(target_os = "ios", target_os = "macos")), feature = "gfx-backend-vulkan"))] |
Collaborator
There was a problem hiding this comment.
Why can't we only write feature = "gfx-backend-vulkan" here, like some of the other places in this commit? It seems like they should all be consistent
Member
Author
|
I don't think we can have just "feature = vulkan" in the code since on some platforms it's not a feature. The reason we have a few of those lines in this PR is because there is a platform-dependent config gate somewhere above already, e.g. bors r=grovesnL |
Contributor
Build succeeded |
kvark
added a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
336: Update wgpu dependency r=kvark a=kvark Includes a fix to gfx-rs#333 Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #321