Merged
Conversation
grovesNL
approved these changes
Oct 28, 2018
| @@ -0,0 +1,19 @@ | |||
| lunarg_core_validation.debug_action = VK_DBG_LAYER_ACTION_LOG_MSG | |||
Collaborator
There was a problem hiding this comment.
Is this committed intentionally?
| } | ||
|
|
||
| pub fn create_pipeline_layout(&self, desc: &PipelineLayoutDescriptor) -> PipelineLayout { | ||
| //TODO: avoid allocation here |
Collaborator
There was a problem hiding this comment.
If these structs became transparent new types around ID then I guess we wouldn't need these maps at all (unless we need to add more fields to these structs in the future)
Member
Author
|
Thanks!
Bors r=grovesNL
… On Oct 28, 2018, at 15:40, Josh Groves ***@***.***> wrote:
@grovesNL approved this pull request.
Looks great!
In examples/vk_layer_settings.txt:
> @@ -0,0 +1,19 @@
+lunarg_core_validation.debug_action = VK_DBG_LAYER_ACTION_LOG_MSG
Is this committed intentionally?
In wgpu-rs/src/lib.rs:
> @@ -170,10 +171,15 @@ impl Device {
}
pub fn create_pipeline_layout(&self, desc: &PipelineLayoutDescriptor) -> PipelineLayout {
+ //TODO: avoid allocation here
If these structs became transparent new types around ID then I guess we wouldn't need these maps at all (unless we need to add more fields to these structs in the future)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
bors bot
added a commit
that referenced
this pull request
Oct 28, 2018
24: Actually begin render passes r=grovesNL a=kvark For now, we create the render pass and the frame buffer in place. Of course, we'd need to cache it properly, but this is blocked on W3C discussions on the API side. With this PR, the Rust example is able to create a texture and run a render pass on it, all without a single Vulkan validation error 🎉 Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, we create the render pass and the frame buffer in place. Of course, we'd need to cache it properly, but this is blocked on W3C discussions on the API side.
With this PR, the Rust example is able to create a texture and run a render pass on it, all without a single Vulkan validation error 🎉