Merged
Conversation
Member
Author
|
This doesn't look great at all, unfortunately. Neither the implementation of |
grovesNL
reviewed
Jul 1, 2019
wgpu-native/src/hub.rs
Outdated
| /// If type A implements `Access<B>`, that means we are allowed to proceed | ||
| /// with locking resource `B` after we lock `A`. | ||
| /// | ||
| /// The impmenentations basically describe the edges in a directed graph |
wgpu-native/src/device.rs
Outdated
| // Before destruction, a resource is expected to have the following strong refs: | ||
| // 1. in resource itself | ||
| // 2. in the device tracker | ||
| // 3. in this list |
Collaborator
There was a problem hiding this comment.
I think we need to add a fourth item to this list?
Member
Author
There was a problem hiding this comment.
actually, no :)
once it has 4 references, it's no longer a resource "before destruction"
80701f4 to
622f686
Compare
Member
Author
|
@grovesNL fixed the typo and CI, PTAL! |
Member
Author
|
@grovesNL rebased and resolved the conflict. Would you want to finish this review? |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66
cc @jrmuizel @m4b