Merged
Conversation
8ad0281 to
138e436
Compare
kvark
approved these changes
Nov 29, 2021
Member
kvark
left a comment
There was a problem hiding this comment.
Thank you!
We'll also need a check to prevent buffer -> depth copies, but this can be done separately (or maybe it's already in).
cwfitzgerald
pushed a commit
that referenced
this pull request
Oct 25, 2023
* spv-out: support version 1.4 * Extract SPV version numner from the comment
EriKWDev
pushed a commit
to bitwise-git/wgpu
that referenced
this pull request
May 14, 2024
This was previously added in gfx-rs#2230 but I don't think it was necessary. gfx-rs#901 already implemented the buffer <-> texture validation for those formats. It's also not a requirement in the spec.
jimblandy
pushed a commit
to jimblandy/wgpu
that referenced
this pull request
May 23, 2024
This was previously added in gfx-rs#2230 but I don't think it was necessary. gfx-rs#901 already implemented the buffer <-> texture validation for those formats. It's also not a requirement in the spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
n/a
Description
Currently, depth texture cannot use the COPY_SRC or COPY_DST usage flag, this is now possible. The copy checks the whole texture is copied.
Testing
Debian bullseye, Nvidia + VK backend