hal/dx12: support base vertex/instance#1731
Merged
bors[bot] merged 1 commit intogfx-rs:masterfrom Jul 27, 2021
Merged
Conversation
cwfitzgerald
approved these changes
Jul 27, 2021
Member
cwfitzgerald
left a comment
There was a problem hiding this comment.
Looks right and if it passes tests (woooooooooooooo!) I'm content!
bors r+
Member
|
errr, CI mad bors r- |
bors bot
added a commit
that referenced
this pull request
Jul 27, 2021
1731: hal/dx12: support base vertex/instance r=cwfitzgerald a=kvark **Connections** Fixes #1725 Depends on gfx-rs/naga#1141, gfx-rs/d3d12-rs#34, and gfx-rs/d3d12-rs#35 (thanks `@msiglreith` for quick reviews!). **Description** We allocate one root parameter covering the special constant buffer view with root constants. We set the root constants for each draw, but only on change. This PR does *not* handle the indirect case. I'll follow-up with this. **Testing** Not thoroughly tested, but `@cwfitzgerald` already implemented a test for this, and this PR enables it on DX12. Also, examples still seem to work :) Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Contributor
|
Canceled. |
Closed
Member
Author
|
gooood CI |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #1725
Depends on gfx-rs/naga#1141, gfx-rs/d3d12-rs#34, and gfx-rs/d3d12-rs#35 (thanks @msiglreith for quick reviews!).
Description
We allocate one root parameter covering the special constant buffer view with root constants. We set the root constants for each draw, but only on change.
This PR does not handle the indirect case. I'll follow-up with this.
Testing
Not thoroughly tested, but @cwfitzgerald already implemented a test for this, and this PR enables it on DX12.
Also, examples still seem to work :)