Merged
Conversation
019c42a to
618cf36
Compare
csnewman
commented
Apr 8, 2021
| }) | ||
| } | ||
|
|
||
| fn create_buffer_descriptor<'a>( |
Contributor
Author
There was a problem hiding this comment.
This method has too many arguments causing a clippy error. Not sure the best way to clean this up.
Member
There was a problem hiding this comment.
in the worst case, just add the [allow(...)] on it
cwfitzgerald
approved these changes
Apr 9, 2021
Member
|
Let's make clippy happy and turn this into a non-draft PR |
Member
|
@csnewman can we finish this for 0.8? |
618cf36 to
48249e5
Compare
48249e5 to
904ec7a
Compare
Member
|
Taking this over now |
Member
|
bors r+ |
Contributor
bors bot
added a commit
to gfx-rs/wgpu-rs
that referenced
this pull request
Apr 29, 2021
850: Add uniform and storage buffer arrays r=kvark a=csnewman **Connections** gfx-rs/wgpu#1315 **Description** Adds uniform and storage buffer arrays Usage: ``` wgpu::BindGroupEntry { binding: 0, resource: BindingResource::BufferArray(&[ buffer1.as_entire_buffer_binding(), buffer2.as_entire_buffer_binding(), ]), } ``` Co-authored-by: Chandler Newman <chandler2newman@hotmail.co.uk>
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
850: Add uniform and storage buffer arrays r=kvark a=csnewman **Connections** gfx-rs#1315 **Description** Adds uniform and storage buffer arrays Usage: ``` wgpu::BindGroupEntry { binding: 0, resource: BindingResource::BufferArray(&[ buffer1.as_entire_buffer_binding(), buffer2.as_entire_buffer_binding(), ]), } ``` Co-authored-by: Chandler Newman <chandler2newman@hotmail.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
gfx-rs/wgpu-rs#850
Description
Adds buffer array bindings
Testing
TODO