Change run_forever() to poll_events()#122
Closed
psincf wants to merge 3 commits intogfx-rs:masterfrom
psincf:master
Closed
Change run_forever() to poll_events()#122psincf wants to merge 3 commits intogfx-rs:masterfrom psincf:master
psincf wants to merge 3 commits intogfx-rs:masterfrom
psincf:master
Conversation
Member
|
Looks good, thank you! |
Contributor
Author
mitchmindtree
pushed a commit
to mitchmindtree/wgpu
that referenced
this pull request
Feb 23, 2020
122: Wholesome update for the git master of wgpu-native r=grovesNL a=kvark Depends on gfx-rs#382 Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
kvark
added a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
122: Wholesome update for the git master of wgpu-native r=grovesNL a=kvark Depends on gfx-rs#382 Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
RandyMcMillan
pushed a commit
to RandyMcMillan/wgpu
that referenced
this pull request
Jun 19, 2024
Event subscriptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to rust-windowing/winit#276,
run_forever()can slow the program.Because the presentation mode of the swap chain is FIFO, when
get_next_texture()is called, it is waiting for the next refresh. If the amout of event per second is superior to the refresh rate, the whole program accumulate event, and closing the window can take a lot of time.poll_events()prevents this.See also rust-windowing/winit#459