Conversation
|
@kvark I've got a quick question about EGL, which is used by Do you know what needs to be installed on the host to get EGL to load? |
|
Probably |
|
Strangely, I have that and it still won't work anyway. Oh, well, thanks for the hint. I'm not going to worry too much about it . I just needed it for the debugger to work, but I'll be fine without it for now. OK, so I've gotten your changes to surfman pulled locally and I've gotten all setup to work on the
Is that along the right lines? |
3e1f8b1 to
375af89
Compare
My changes were merged into surfman proper in servo/surfman#185, you shouldn't need my branch, just use
Correct! Also, the adapters may need to create their own GL contexts, depending on exposed/requested features. If you expose only a single adapter, you can just re-use the context from the instance, that's simpler. |
|
Haha! Finally got this working I think! I haven't switched to using the official I also started work on porting WGPU to the latest GFX and including support for OpenGL and it is going very well so far. Hope to have this finished soon! |
7b6dd03 to
74d9891
Compare
|
OK, I think this is good now. ( Pending CI ). |
kvark
left a comment
There was a problem hiding this comment.
Looks like we are almost there!
|
Seems to be working on macOS. Although, we'd need to test the wgpu-rs samples before publishing the gfx backend. |
Oh, sweet.
Yeah, sounds like a good idea. That was the issue last time: we didn't find the issues with the backend until we tried hooking it up to WGPU. |
74d9891 to
7ce64ca
Compare
|
Nice to have a near-instant CI now, isn't it? :) |
|
Uh, yeah, that's pretty nice. :) |
7ce64ca to
31f61a5
Compare
|
If I've estimated correctly I should be able to test this with WGPU very soon. I'll have a PR on WGPU and we'll figure out how well this works with the WGPU examples. |
|
Please rebase and squash |
31f61a5 to
8f9fcac
Compare
|
Done. And, hey, we deleted more lines of code than we added. 🎉 |
|
Ah, oops, I made the GL backend only included in the examples for |
|
Let's disable it on Windows completely |
|
that also means we don't need to enable WGL dependency |
8f9fcac to
68658df
Compare
Fix the OpenGL backend for Linux and MacOS, utilizing the new context sharing in surfman 0.3.
68658df to
a1bf8a2
Compare
kvark
left a comment
There was a problem hiding this comment.
Beautiful!
Let's get this into master.
bors r+
|
Yay! 🎉 Thanks so much for your help @kvark. Couldn't have done it without your guidance. 😄 Next up, WGPU! |
907: Implement OpenGL Backend For Unix Platforms r=kvark a=zicklag **Connections** Requires: gfx-rs/gfx#3340 ( merged ) Should be merged first: #910 Works towards: #450 **Description** Integrates the GFX GL backend for Unix platforms **Testing** Runs the basic cube and triangle examples for wgpu-rs, but not without rendering artifacts on the cube. <!-- Non-trivial functional changes would need to be tested through: - [wgpu-rs](https://github.com/gfx-rs/wgpu-rs) - test the examples. - [wgpu-native](https://github.com/gfx-rs/wgpu-native/) - check the generated C header for sanity. Ideally, a PR needs to link to the draft PRs in these projects with relevant modifications. See #666 for an example. If you can add a unit/integration test here in `wgpu`, that would be best. --> Co-authored-by: Zicklag <zicklag@katharostech.com>
907: Implement OpenGL Backend For Unix Platforms r=kvark a=zicklag **Connections** Requires: gfx-rs/gfx#3340 ( merged ) Should be merged first: #910 Works towards: #450 **Description** Integrates the GFX GL backend for Unix platforms **Testing** Runs the basic cube and triangle examples for wgpu-rs, but not without rendering artifacts on the cube. <!-- Non-trivial functional changes would need to be tested through: - [wgpu-rs](https://github.com/gfx-rs/wgpu-rs) - test the examples. - [wgpu-native](https://github.com/gfx-rs/wgpu-native/) - check the generated C header for sanity. Ideally, a PR needs to link to the draft PRs in these projects with relevant modifications. See #666 for an example. If you can add a unit/integration test here in `wgpu`, that would be best. --> Co-authored-by: Zicklag <zicklag@katharostech.com>

WIP getting GL finally working again with
surfman.PR checklist:
makesucceeds (on *nix)make reftestssucceeds ( Fails because of things unimplemented in GL backend. Out of scope for this PR )