Conversation
Fixes up #434. We sometimes load Spotlight befor a Sentry SDK is loaded which then bails on running the integration with it, making it lose most of its appeal. To fix this, this PR adds a retry mechanism which tries detecting Sentry SDK up to 3 times. This works on the first try if it's just an ordering problem. It however would not work where a Sentry SDK is loaded on-demand as we don't have an "on load event" for Sentry SDK.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dcramer
approved these changes
Jul 22, 2024
dcramer
pushed a commit
that referenced
this pull request
Jun 3, 2025
Fixes up #434. We sometimes load Spotlight befor a Sentry SDK is loaded which then bails on running the integration with it, making it lose most of its appeal. To fix this, this PR adds a retry mechanism which tries detecting Sentry SDK up to 3 times. This works on the first try if it's just an ordering problem. It however would not work where a Sentry SDK is loaded on-demand as we don't have an "on load event" for Sentry SDK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes up #434.
We sometimes load Spotlight befor a Sentry SDK is loaded which
then bails on running the integration with it, making it lose
most of its appeal. To fix this, this PR adds a retry mechanism
which tries detecting Sentry SDK up to 3 times.
This works on the first try if it's just an ordering problem. It
however would not work where a Sentry SDK is loaded on-demand as
we don't have an "on load event" for Sentry SDK.