Merged
Conversation
The current client init code generation is a bit fragile. It also does not pass the sidecarUrl option to any other potential integrations. This PR fixes that issue and makes the code generation more robust and readable.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Shubhdeep12
requested changes
Jun 30, 2024
Shubhdeep12
approved these changes
Jul 2, 2024
Collaborator
Shubhdeep12
left a comment
There was a problem hiding this comment.
Creating a separate issue for
- updating docs for custom intrgrations.
- to make sidecarURL (optional) in other intrgrations provided by Spotlight.
- to pass tye sidecarURL from Spotlight.init to the integration's options if the integrations array is paased by props while initiating Spotlight.
3 tasks
kensternberg-authentik
added a commit
to kensternberg-authentik/spotlight
that referenced
this pull request
Jul 15, 2024
…rybook-8-compatibility * origin/HEAD: fix: Overhaul envelope parsing to be spec compliant (getsentry#439) fix: Always trim befor trying to JSON.parse (getsentry#438) Highlighted active span and event (getsentry#437) ref: Use new event helpers (getsentry#433) fix: Remove forgotton console.log statement feat: POC for adding spotlight overlay for ssr-errors (getsentry#364) ref: More concise event helpers (getsentry#431) fix: Fix CI issues (getsentry#432) fix: Send something immediately to trigger open event (getsentry#429) ref: More robust client init code generation (getsentry#426) docs: Add note about Volta - pnpm support (getsentry#425) Added Search in Trace detail (getsentry#424) Added Trace Info (getsentry#423) chore(deps-dev): bump vite from 4.5.2 to 4.5.3 (getsentry#392) chore(deps): bump braces from 3.0.2 to 3.0.3 (getsentry#415) docs: Add build step to initial setup (getsentry#418)
dcramer
pushed a commit
that referenced
this pull request
Jun 3, 2025
The current client init code generation is a bit fragile. It also does not pass the sidecarUrl option to any other potential integrations. This PR fixes that issue and makes the code generation more robust and readable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current client init code generation is a bit fragile. It also does not pass the sidecarUrl option to any other potential integrations. This PR fixes that issue and makes the code generation more robust and readable.