This repository was archived by the owner on Dec 4, 2023. It is now read-only.
Conversation
We want to be able to run the action on release branches as well. This adds a new option` run_for_branch` which can be set to overwrite the default `isMainBranch` detection. When this is set to `'true'`, it will run size limit for the given branch without any comparison. Set it to unset or `''` to revert to the default main branch detection.
mydea
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Feb 17, 2023
Based on getsentry/size-limit-action#8, this ensures we can actually run size-limit on release branches, which currently fails.
Lms24
approved these changes
Feb 17, 2023
mydea
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Feb 17, 2023
Based on getsentry/size-limit-action#8, this ensures we can actually run size-limit on release branches, which currently fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to run size limit on release branches, in order to include this information in the github release (see https://github.com/getsentry/size-limit-release). In order to make this happen, we need to be able to trigger size limit on non-default branches as well.
This allows to pass a new optional
run_for_branchboolean option. If this is set to true, it will run as it currently does for the default branch. If this is not set, it will keep doing what it does right now.