Skip to content

ref(sveltekit): Use clack as a CLI prompt#260

Merged
Lms24 merged 3 commits intolms/sveltekit-supportfrom
lms/sveltekit-clack
May 2, 2023
Merged

ref(sveltekit): Use clack as a CLI prompt#260
Lms24 merged 3 commits intolms/sveltekit-supportfrom
lms/sveltekit-clack

Conversation

@Lms24
Copy link
Copy Markdown
Member

@Lms24 Lms24 commented Apr 21, 2023

  • Move the SvelteKit setup wizard to the new src dir
  • Use clack as CLI prompt
  • Replace template files with template strings
  • Split up Sveltekit code into multiple files
  • Adjust originial SvelteKit Integration class to just redirect to the new setup (cc @lforst we probably wanna do something like this for NextJS)
  • Extract lookup of framework package to helper

#skip-changelog

ref #244

@Lms24 Lms24 requested review from AbhiPrasad and lforst April 21, 2023 14:33
@Lms24 Lms24 self-assigned this Apr 21, 2023
Copy link
Copy Markdown

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me. Left a few notes - I'll leave the decisions up to you! Feel free to merge any time. Wizard is low-risk.

Copy link
Copy Markdown

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me. Left a few notes - I'll leave the decisions up to you! Feel free to merge any time. Wizard is low-risk.

@Lms24 Lms24 merged commit 2db0fd3 into lms/sveltekit-support May 2, 2023
@Lms24 Lms24 deleted the lms/sveltekit-clack branch May 2, 2023 06:30
Lms24 added a commit that referenced this pull request May 3, 2023
Converts the CLI appearance to use the `clack` library. Rewriting the flow to the new NextJS wizard flow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants