feat(sveltekit): Use magicast to insert Sentry.init and vite plugin#257
Merged
Lms24 merged 1 commit intolms/sveltekit-supportfrom Apr 21, 2023
Merged
feat(sveltekit): Use magicast to insert Sentry.init and vite plugin#257Lms24 merged 1 commit intolms/sveltekit-supportfrom
magicast to insert Sentry.init and vite plugin#257Lms24 merged 1 commit intolms/sveltekit-supportfrom
Conversation
|
AbhiPrasad
approved these changes
Apr 20, 2023
ae578cc to
cbd6f61
Compare
Lms24
added a commit
that referenced
this pull request
Apr 21, 2023
…#257) Replace the "old" init call injection approach with using magicast to modify the file
Lms24
added a commit
that referenced
this pull request
May 3, 2023
…#257) Replace the "old" init call injection approach with using magicast to modify the file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So.. We might get into trouble for this but magicast is super nice IMO!
This PR replaces the "old" init call injection approach with using magicast to modify the file. It's a bit hacky as magicast doesn't provide proper API to do this but it works overall pretty well and I have a better feeling about it than using regex for it (we'll see if that holds up 😅)
Furthermore, this PR uses the super-nice top-level magicast helper
addVitePluginto add our plugin constructor to the vite config. This brings the manual setup down to two steps!#skip-changelog
ref #244