feat(sveltekit): Read hook file paths from svelte.config.js#253
Merged
Lms24 merged 1 commit intolms/sveltekit-supportfrom Apr 20, 2023
Merged
feat(sveltekit): Read hook file paths from svelte.config.js#253Lms24 merged 1 commit intolms/sveltekit-supportfrom
svelte.config.js#253Lms24 merged 1 commit intolms/sveltekit-supportfrom
Conversation
|
AbhiPrasad
approved these changes
Apr 20, 2023
Lms24
added a commit
that referenced
this pull request
Apr 21, 2023
To respect custom hooks file locations that users can specifiy in `svelte.config.js`, we import the svelte config and use these custom paths if they're available. Otherwise, we fall back to the default paths.
Lms24
added a commit
that referenced
this pull request
May 3, 2023
To respect custom hooks file locations that users can specifiy in `svelte.config.js`, we import the svelte config and use these custom paths if they're available. Otherwise, we fall back to the default paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To respect custom hooks file locations that users can specifiy in
svelte.config.js, we import the svelte config and use these custom paths if they're available. Otherwise, we fall back to the default paths.This PR adjusts the
tsconfig.jsonto usenode16module resolution and code generation. This allows us to keep using tsc for the moment and preserveawait importcalls (so that they're not transpiled torequire). I checked and it seems like the transpiled code is mostly equal to what we had before. However, reading the config will only work if users are using Node 16+. For older Node versions, the wizard will emit a warning and instruct people to use it with Node 16. IMO this is fine for the SvelteKit setup flow because SvelteKit requires Node 16 anyway as a minimum version.closes #247
#skip-changelog