Skip to content

feat(sveltekit): Add SvelteKit menu option and SDK installation#245

Merged
Lms24 merged 1 commit intolms/sveltekit-supportfrom
lms/sveltekit-add-menu
Apr 19, 2023
Merged

feat(sveltekit): Add SvelteKit menu option and SDK installation#245
Lms24 merged 1 commit intolms/sveltekit-supportfrom
lms/sveltekit-add-menu

Conversation

@Lms24
Copy link
Copy Markdown
Member

@Lms24 Lms24 commented Apr 17, 2023

This PR marks the first step of adding Wizard support for the SvelteKit SDK:

  • Add SvelteKit integration class
  • SvelteKit can be selected in the integration selection prompt
  • Support for -i sveltekit option
  • Check if compatible SvelteKit version or SvelteKit SDK version is installed
  • Install @sentry/sveltekit package if not yet installed

I'm not sure about the release cadence of the wizard. Happy to merge the steps into a branch for now and release in one go later on if we don't want the halfway-finished SvelteKit menu option to show up before it is finished.

For now:
#skip-changelog

ref #244

@Lms24 Lms24 requested review from AbhiPrasad and lforst April 17, 2023 12:52
@Lms24 Lms24 self-assigned this Apr 17, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 17, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against e3e6dbc

*
* @returns `true` if the package is installed, `false` otherwise
*/
export function hasPackageInstalled(
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracted this from the NextJS integration class. Will probably extract more methods going forward as the initial setup is very similar

@Lms24 Lms24 force-pushed the lms/sveltekit-add-menu branch 2 times, most recently from ed81f0b to e3156c1 Compare April 17, 2023 13:07
@Lms24 Lms24 changed the base branch from master to lms/sveltekit-support April 19, 2023 11:44
@Lms24 Lms24 force-pushed the lms/sveltekit-add-menu branch 3 times, most recently from 9b42e48 to c6632cd Compare April 19, 2023 12:04
@Lms24 Lms24 force-pushed the lms/sveltekit-add-menu branch from c6632cd to e3e6dbc Compare April 19, 2023 12:05
@Lms24 Lms24 merged commit 3718212 into lms/sveltekit-support Apr 19, 2023
@Lms24 Lms24 deleted the lms/sveltekit-add-menu branch April 19, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants