Skip to content

Support for axum 0.7.1#627

Merged
Swatinem merged 1 commit intogetsentry:masterfrom
benjaminjellis:bump_http_to_support_axum_0_7
Nov 28, 2023
Merged

Support for axum 0.7.1#627
Swatinem merged 1 commit intogetsentry:masterfrom
benjaminjellis:bump_http_to_support_axum_0_7

Conversation

@benjaminjellis
Copy link
Contributor

@benjaminjellis benjaminjellis commented Nov 28, 2023

Hi,

I'm not sure if you accept contributions so feel free to close this if not.

Axum recently update to 0.7.0 which doesn't compile using sentry 0.31.8, as it turns out this is simple to fix by bumping the http dependency in sentry-tower to 1.0.0 to match that in axum.

@TimDiekmann TimDiekmann mentioned this pull request Nov 28, 2023
Merged
3 tasks
@TimDiekmann
Copy link

TimDiekmann commented Nov 28, 2023 •
edited
Loading

I was about to open the exact same PR 😄.
I tested bumping http to 1.0 in sentry-tower locally and it seems to work. However, sentry uses a bunch of dev-dependencies, which still indirectly rely on the old 0.2.9 version of http and I think this is why the changes to Cargo.lock includes old versions.

Swatinem
Swatinem approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m a bit surprised this is the only thing that needs bumping, I thought there was more in the tower ecosystem that had version bumps due to hyper.

@Swatinem Swatinem enabled auto-merge (squash) November 28, 2023 08:21
@Swatinem Swatinem merged commit 6f1ac71 into getsentry:master Nov 28, 2023
@TimDiekmann
Copy link

TimDiekmann commented Nov 28, 2023

I don't know the typical release flow for sentry, is it just the release workflow dispatch? If so, would it be possible to trigger it?

@indietyp
Copy link

indietyp commented Nov 28, 2023

Also it appears like http 0.2 is still in the dependency tree, axum and actix seem to need updating as well. 🤔

@Swatinem
Copy link
Contributor

Swatinem commented Nov 28, 2023

I did a ton more dependency updates in #628

jan-auer added a commit that referenced this pull request Dec 11, 2023
@jan-auer
Merge branch 'master' into swatinem/metrics
255c578 
* master:
  tracing: send spans' attributes along with the event ones (#629)
  release: 0.32.0
  Update crate dependencies (#628)
  feat: bump http to 1.0.0 (#627)
  release: 0.31.8
  MonitorSchedule constructor that validates crontab syntax (#625)
  fix(docs): Fix some doc errors that slipped in (#623)
  docs(tower): Mention how to enable http feature from sentry crate (#622)
  build(deps): bump rustix from 0.37.23 to 0.37.25 (#619)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Swatinem Swatinem Swatinem approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@benjaminjellis @TimDiekmann @indietyp @Swatinem