Skip to content

Bump faraday version to latest#946

Merged
HazAT merged 1 commit intogetsentry:masterfrom
ksylvest:bump-faraday-from-v0.7.6-to-v1.0.0
Jan 29, 2020
Merged

Bump faraday version to latest#946
HazAT merged 1 commit intogetsentry:masterfrom
ksylvest:bump-faraday-from-v0.7.6-to-v1.0.0

Conversation

@ksylvest
Copy link
Copy Markdown
Contributor

@ksylvest ksylvest commented Jan 14, 2020 •
edited
Loading

Bumping required faraday version to v1.0.0 from v0.7.6. This requires dropping support for Ruby 2.2 - but fixes Ruby 2.7. For details see:

https://github.com/lostisland/faraday/blob/master/CHANGELOG.md#v10

@ksylvest ksylvest marked this pull request as ready for review January 14, 2020 05:35
@ksylvest
Bump faraday version to latest
eddd379 
Bumping required faraday version to v1.0.0 from v0.7.6. This requires
dropping support for Ruby 2.2 - but fixes Ruby 2.7. For details see:

https://github.com/lostisland/faraday/blob/master/CHANGELOG.md#v10
@scottbartell scottbartell mentioned this pull request Jan 21, 2020
Closed
@FraDim
Copy link
Copy Markdown

FraDim commented Jan 27, 2020

@HazAT, do you think that this is ready to merge?

@HazAT
Copy link
Copy Markdown
Member

HazAT commented Jan 28, 2020

Thanks for the PR, can you add ruby 2.7 to the matrix plz?

@ksylvest
Copy link
Copy Markdown
Contributor Author

ksylvest commented Jan 29, 2020

@HazAT not easily: 2fe3e95 (similar to how HEAD is failing in master right now). Have an issue that hasn't been responded to for this:

https://github.com/getsentry/raven-ruby/issues/947

It looks like the behaviour of JSON changed slightly between v2.6.5 and v2.7.0. I'd prefer to fix the testing of JSON in the standard library separate from bumping faraday versions if possible.

@HazAT
Copy link
Copy Markdown
Member

HazAT commented Jan 29, 2020

OK, I am merging this but I want to wait with a release until we fixed 2.7.0

HazAT
HazAT approved these changes Jan 29, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THX 🥇

@HazAT HazAT merged commit 2e4378d into getsentry:master Jan 29, 2020
@meal
Copy link
Copy Markdown

meal commented Jan 29, 2020

any ETA for new gem version release with this PR?

@ksylvest ksylvest deleted the bump-faraday-from-v0.7.6-to-v1.0.0 branch January 30, 2020 06:27
@ksylvest ksylvest mentioned this pull request Jan 30, 2020
Merged
@tanelsuurhans
Copy link
Copy Markdown

tanelsuurhans commented Feb 5, 2020

Any updates on a release?

@HazAT
Copy link
Copy Markdown
Member

HazAT commented Feb 21, 2020

We will do a release next week, after merging: #952

@pdkproitf
Copy link
Copy Markdown

pdkproitf commented Mar 2, 2020

@HazAT Can you confirm the release day?

I got problems with the old faraday version.

@HazAT
Copy link
Copy Markdown
Member

HazAT commented Mar 2, 2020

Released 3.0.0 just now.

@giovannibonetti giovannibonetti mentioned this pull request Aug 3, 2020
Closed
@cstyles cstyles mentioned this pull request Apr 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HazAT HazAT HazAT approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ksylvest @FraDim @HazAT @meal @tanelsuurhans @pdkproitf