Drop Failing Spec for Circular References in Hashes#952
Merged
HazAT merged 1 commit intogetsentry:masterfrom Mar 2, 2020
ksylvest:ksylvest/fix-ci-for-json
Merged
Drop Failing Spec for Circular References in Hashes#952HazAT merged 1 commit intogetsentry:masterfrom ksylvest:ksylvest/fix-ci-for-json
HazAT merged 1 commit intogetsentry:masterfrom
ksylvest:ksylvest/fix-ci-for-json
Conversation
Contributor
Author
|
@HazAT wanted to followup from the change introduced here: https://github.com/getsentry/raven-ruby/pull/946 I see a few different options:
Do you have any thoughts? #2 seems like the best option to me (since this test is a bit overbearing). Commit that introduced spec for reference: ccb88bb |
Contributor
Author
|
@HazAT do you know if anyone on the sentry team is available to help with issues / PRs? |
Member
|
Hey, sorry about that. WRT to this PR, I would say #2 is fine. |
The `JSON` 2.3.0 gem changed how parsing errors are raised. For example:
require 'json'
data = {}
data['cycle'] = data
JSON.dump(data)
With json v2.2.0:
This raises a `SystemStackError`.
With json v2.3.0:
This causes `fatal (machine stack overflow in critical region)`
Since the specs depend on 'SystemStackError' removing.
Contributor
Author
|
Adjusted this PR to use no. 2. |
HazAT
approved these changes
Mar 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for https://github.com/getsentry/raven-ruby/issues/947.
The
JSON2.3.0 gem changed how parsing errors are raised. For example:With json v2.2.0:
This raises a
SystemStackError.With json v2.3.0:
This causes
fatal (machine stack overflow in critical region)