Use :job instead of "job" and prefer "wrapped" over "class"#635
Closed
vindvaki wants to merge 1 commit intogetsentry:masterfrom
Closed
Use :job instead of "job" and prefer "wrapped" over "class"#635vindvaki wants to merge 1 commit intogetsentry:masterfrom
vindvaki wants to merge 1 commit intogetsentry:masterfrom
Conversation
Contributor
|
Sigh, this is actually #622. The context hash may be symbols or strings. I'm wondering if I should just leave this for 3.0, when the event hash will always be string-keyed. |
Author
|
Fair enough. Just remember that there are two things going on here:
The former issue remains regardless of the latter, but there's already an issue open for that in #630. And TBH I don't even know if this PR would break other people's code 😝, so feel free to close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took a stab at https://github.com/getsentry/raven-ruby/issues/630 myself and noticed that
"job"key should have been:job, which explains why we were getting the culpritSidekiq(implying
classname == nil) instead of the value ofcontext[:job]["class"], which isfor wrapped jobs.