Skip to content

Exceptions from wrapped ActiveJob Sidekiq jobs lacking context #630

@vindvaki

Description

@vindvaki

After upgrading raven-ruby from an ancient version to the latest version, the only context we get for exceptions raised by workers is Sidekiq, greatly reducing the usefulness the list view (lots of errors look the same). Basically, all our worker errors are generic stuff like:

screen shot 2017-01-31 at 16 30 26

whereas before we used to have the file name of the template where the exception was raised.

I've been digging around and it seems like https://github.com/getsentry/raven-ruby/blob/master/lib/raven/integrations/sidekiq.rb#L48 might be missing the case of wrapped jobs, in which case

context["job"]["wrapped"]

contains at least the job class name (in this case MailJob), which would already be a huge improvement over simply Sidekiq.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions