Closed
Conversation
3a03add to
b0b2e02
Compare
b0b2e02 to
53c5bca
Compare
Contributor
Author
|
Ultimately I decided not to include local variable capture - it's too unstable and buggy and could never be used in production, so the use case is too limited. |
53c5bca to
fa7489b
Compare
Contributor
Author
|
Just realized we'll need a 2.x series release where |
fa7489b to
55494dd
Compare
f7a6f43 to
0fb65bf
Compare
Remove “capture” methods on Raven::Event, which no one should have been using directly anyway because those methods didn’t “capture” anything, only converted strings/exceptions into Events. I’m not going to do a deprecation cycle for this because no one should have been using these aliases anyway, and they were only used in our tests. I do recognize that from_exception is now changed so that it no longer checks Raven::Error or excluded exception (that’s now in capture_allowed?), so this will trigger a major release.
+ Config can be passed variables during init + Spec -> Minitest + Bad encoding raises ArgumentError + ResolveHostname - fix bug where FQDN was not resolved + Note bug where module exclusion doesn’t work properly
24c65cc to
04bd6ed
Compare
This was referenced Jun 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transport_failure_callbackgives no information on failure reason #661Raven.configurationglobal exists.