Skip to content

Skip creating LogEventBuffer if logging is not enabled#2652

Merged
solnic merged 2 commits intomasterfrom
2651-skip-log-event-buffer-if-logging-not-enabled
Jun 17, 2025
Merged

Skip creating LogEventBuffer if logging is not enabled#2652
solnic merged 2 commits intomasterfrom
2651-skip-log-event-buffer-if-logging-not-enabled

Conversation

@solnic
Copy link
Copy Markdown
Collaborator

@solnic solnic commented Jun 16, 2025 •
edited
Loading

Fixes #2651

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.37%. Comparing base (5fdf3be) to head (f09ec3d).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2652      +/-   ##
==========================================
- Coverage   96.67%   95.37%   -1.31%     
==========================================
  Files         133      133              
  Lines        5145     5143       -2     
==========================================
- Hits         4974     4905      -69     
- Misses        171      238      +67
Components Coverage Δ
sentry-ruby 95.33% <100.00%> (-1.80%) ⬇️
sentry-rails 94.91% <ø> (+<0.01%) ⬆️
sentry-sidekiq 95.81% <ø> (+1.14%) ⬆️
sentry-resque 94.44% <ø> (ø)
sentry-delayed_job 94.68% <ø> (ø)
sentry-opentelemetry 98.62% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/client.rb 99.40% <100.00%> (+<0.01%) ⬆️

... and 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@solnic solnic marked this pull request as ready for review June 17, 2025 08:49
@solnic solnic force-pushed the 2651-skip-log-event-buffer-if-logging-not-enabled branch from 9dd118f to f09ec3d Compare June 17, 2025 08:51
@solnic solnic requested a review from sl0thentr0py June 17, 2025 09:03
@solnic solnic merged commit 32ca39e into master Jun 17, 2025
139 of 140 checks passed
@solnic solnic deleted the 2651-skip-log-event-buffer-if-logging-not-enabled branch June 17, 2025 09:32
@solnic solnic mentioned this pull request Jun 17, 2025
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 17, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Skip creating LogEventBuffer if logging is not enabled ([#2652](https://github.com/getsentry/sentry-ruby/pull/2652))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against f09ec3d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ThreadError can't create Thread: Resource temporarily unavailable when bumping from 5.23.0 to 5.24.0

2 participants

@solnic @sl0thentr0py