Skip to content

[rails] support string errors in error reporter#2464

Merged
solnic merged 4 commits intomasterfrom
solnic/2460-using-activesupporterrorreporter-with-capture_message
Nov 16, 2024
Merged

[rails] support string errors in error reporter#2464
solnic merged 4 commits intomasterfrom
solnic/2460-using-activesupporterrorreporter-with-capture_message

Conversation

@solnic
Copy link
Copy Markdown
Collaborator

@solnic solnic commented Nov 14, 2024

Closes #2460

@solnic solnic linked an issue Nov 14, 2024 that may be closed by this pull request
Using ActiveSupport::ErrorReporter with capture_message #2460
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.13%. Comparing base (5de4ebc) to head (5f92f21).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2464   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         126      126           
  Lines        4761     4767    +6     
=======================================
+ Hits         4672     4678    +6     
  Misses         89       89
Components Coverage Δ
sentry-ruby 98.51% <ø> (ø)
sentry-rails 97.08% <100.00%> (+0.02%) ⬆️
sentry-sidekiq 96.96% <ø> (ø)
sentry-resque 92.85% <ø> (ø)
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
sentry-rails/lib/sentry/rails/error_subscriber.rb 100.00% <100.00%> (ø)

@solnic solnic marked this pull request as ready for review November 14, 2024 13:19
sl0thentr0py
sl0thentr0py requested changes Nov 14, 2024
View reviewed changes
@solnic solnic requested a review from sl0thentr0py November 15, 2024 15:33
@solnic solnic force-pushed the solnic/2460-using-activesupporterrorreporter-with-capture_message branch from 7feee5e to 5f92f21 Compare November 16, 2024 00:35
@solnic solnic merged commit b31f0f3 into master Nov 16, 2024
@solnic solnic deleted the solnic/2460-using-activesupporterrorreporter-with-capture_message branch November 16, 2024 22:03
@viralpraxis viralpraxis mentioned this pull request Jan 25, 2025
Closed
solnic added a commit that referenced this pull request Jan 29, 2025
@solnic
Revert "[rails] support string errors in error reporter (#2464)"
d4b74f2 
This reverts commit b31f0f3.
solnic added a commit that referenced this pull request Jan 29, 2025
@solnic
Revert "[rails] support string errors in error reporter (#2464)" (#2533)
a8094be 
* Revert "[rails] support string errors in error reporter (#2464)"

This reverts commit b31f0f3.

* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

@st0012 st0012 Awaiting requested review from st0012

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Using ActiveSupport::ErrorReporter with capture_message

2 participants

@solnic @sl0thentr0py