Closed
Conversation
We don't need to use Sidekiq for ActiveJob specs, we can use Rails' default adapters instead.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2445 +/- ##
=======================================
Coverage 98.18% 98.18%
=======================================
Files 126 126
Lines 4726 4726
=======================================
Hits 4640 4640
Misses 86 86
|
solnic
reviewed
Oct 28, 2024
Collaborator
solnic
left a comment
There was a problem hiding this comment.
Just like in the other PR - we probably want to remove sidekiq from Gemfile now
Contributor
Author
|
Merged as part of #2444 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to use Sidekiq for ActiveJob specs, we can use Rails' default adapters instead.
#skip-changelog