Skip to content

Test sentry-rails against Rails 8.0.0#2444

Merged
st0012 merged 4 commits intomasterfrom
update-sentry-rails-dependencies
Oct 28, 2024
Merged

Test sentry-rails against Rails 8.0.0#2444
st0012 merged 4 commits intomasterfrom
update-sentry-rails-dependencies

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Oct 26, 2024 •
edited
Loading

This PR:

  • Includes a commit from Simplify ActiveJob specs setup #2445, which can be merged separately or together
  • Re-organizes Gemfile's Ruby/Rails conditions
  • Updates Rails 8 specific tests
  • Adds Rails 8.0.0.rc1 as test target (which can easily be updated to 8.0)

#skip-changelog

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.18%. Comparing base (9bba2ef) to head (5b5faab).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2444   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files         126      126           
  Lines        4726     4726           
=======================================
  Hits         4640     4640           
  Misses         86       86
Components Coverage Δ
sentry-ruby 98.51% <ø> (ø)
sentry-rails 97.20% <ø> (ø)
sentry-sidekiq 97.47% <ø> (ø)
sentry-resque 92.85% <ø> (ø)
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)

@st0012 st0012 force-pushed the update-sentry-rails-dependencies branch 5 times, most recently from b51f218 to b710d47 Compare October 26, 2024 16:45
@st0012 st0012 mentioned this pull request Oct 26, 2024
Merged
1 task
@st0012 st0012 requested review from sl0thentr0py and solnic October 26, 2024 19:38
@st0012 st0012 marked this pull request as ready for review October 26, 2024 19:38
solnic
solnic approved these changes Oct 28, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@solnic solnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally too and all green

solnic
solnic reviewed Oct 28, 2024
View reviewed changes
sentry-rails/Gemfile Outdated

gem "sprockets-rails"

gem "sidekiq"
Copy link
Copy Markdown
Collaborator

@solnic solnic Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@st0012 we probably no longer need this since test adapter is used for AJ tests

Copy link
Copy Markdown
Contributor Author

@st0012 st0012 Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍 Removed

@st0012 st0012 force-pushed the update-sentry-rails-dependencies branch from 9bc550a to 5b5faab Compare October 28, 2024 11:37
@st0012 st0012 merged commit e384446 into master Oct 28, 2024
@st0012 st0012 deleted the update-sentry-rails-dependencies branch October 28, 2024 11:42
@st0012 st0012 mentioned this pull request Oct 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@solnic solnic solnic approved these changes

@sl0thentr0py sl0thentr0py Awaiting requested review from sl0thentr0py

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@st0012 @solnic