Skip to content

Allow setting defaults for MonitorConfig objects with new Cron::Confi…#2211

Merged
sl0thentr0py merged 3 commits intomasterfrom
neel/cron-config
Dec 29, 2023
Merged

Allow setting defaults for MonitorConfig objects with new Cron::Confi…#2211
sl0thentr0py merged 3 commits intomasterfrom
neel/cron-config

Conversation

@sl0thentr0py
Copy link
Copy Markdown
Member

closes #2205

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 28, 2023

Codecov Report

Merging #2211 (882740e) into master (2f9ffaf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2211   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files         101      102    +1     
  Lines        3805     3814    +9     
=======================================
+ Hits         3705     3714    +9     
  Misses        100      100           
Components Coverage Δ
sentry-ruby 98.07% <100.00%> (+<0.01%) ⬆️
sentry-rails 94.98% <ø> (ø)
sentry-sidekiq 94.70% <ø> (ø)
sentry-resque 92.06% <ø> (ø)
sentry-delayed_job 94.44% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry/configuration.rb 98.78% <100.00%> (+0.01%) ⬆️
sentry-ruby/lib/sentry/cron/configuration.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/cron/monitor_config.rb 100.00% <100.00%> (ø)

Copy link
Copy Markdown
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to change the default grace period and timeout for all Cron Monitors when using the sidekiq_scheduler patches

2 participants