Spotlight Sidecar support in Sentry-Ruby#2175
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2175 +/- ##
=======================================
Coverage 97.34% 97.34%
=======================================
Files 99 100 +1
Lines 3692 3731 +39
=======================================
+ Hits 3594 3632 +38
- Misses 98 99 +1
|
|
@natikgadzhi Added support to the sidecar to accept gzip/deflate encoding |
HazAT
left a comment
There was a problem hiding this comment.
Generally LGTM - since this is a dev only feature and opt-in, I think we are fine with the tests we have but @sl0thentr0py should make sure this is how we want it to be
I already documented it here
https://spotlightjs.com/setup/sentry/
|
Yeah, this is very broken, I’ll work it today ;-)
|
769f14f to
3d29a21
Compare
|
Okay, update time!
As long as @sl0thentr0py is happy, we can merge this as is, so folks can start using it. My approach would be to merge and follow-up with next steps, but while I have time, I'll add things in this PR:
/cc @HazAT |
|
@HazAT, thank you for the Spotlight docs! |
|
taking this over to finish up |
|
tested new changes without DSN 
|
sl0thentr0py
left a comment
There was a problem hiding this comment.
ok i made some changes and added specs
@natikgadzhi @HazAT if you wanna take a quick look, otherwise i'll merge and release tomorrow
|
I’ll look later today, but you should merge it, don’t block on me.
Huge thank you for picking this up ❤️🩹
|
|
discussed with @HazAT - i will add a max 3 retry on the spotlight transport so we don't spam logs in production tomorrow |
|
I saw that in JS SDK, sounds good to be consistent.
Want me to add some docs to the readme here, and to sentry-docs?
|
|
i'm not sure if spotlight docs will be in sentry or separate, leaving that to @HazAT |
4ac6613 to
c83f571
Compare
|
Spotlight docs live here: https://github.com/getsentry/spotlight/tree/main/packages/website (and end up here: https://spotlightjs.com/about/) |
c83f571 to
5e8462d
Compare
The link should point to <#2175> (not "pulls").
Summary
This PR adds Spotlight / Sidecar support to Sentry-Ruby!
This is still work in progress ;) /cc @sl0thentr0py, @cleptric, feedback very welcome!
Changes
Spotlight::Configurationobject that hasenabledandsidecar_urlfields with defaults.Spotlight::Transportthat is similar toHTTPTransport, but YOLO-grade. Doesn't care about rate limits.http_transport.rb(not proud of that one) that callsSpotlight::Transport.new().send_data(data)when it has stuff to send, but before validating rate limits. Aligned with PHP version.TODO
Reviewing