Tracing without performance: new continue_trace api#2089
Merged
sl0thentr0py merged 6 commits intoneel/twpfrom Aug 31, 2023
Merged
Tracing without performance: new continue_trace api#2089sl0thentr0py merged 6 commits intoneel/twpfrom
sl0thentr0py merged 6 commits intoneel/twpfrom
Conversation
Codecov ReportPatch coverage is 📢 Thoughts on this report? Let us know!. |
bdc6359 to
b1bf79f
Compare
05c5f27 to
0afa9a3
Compare
b1bf79f to
abe9393
Compare
abe9393 to
199fdf4
Compare
9ffcc1f to
23a4d06
Compare
600599d to
dfc22a4
Compare
83541fd to
c6d3bfe
Compare
dfc22a4 to
96fe215
Compare
e7d1e9f to
e23bd3a
Compare
e23bd3a to
fd07c39
Compare
cleptric
approved these changes
Aug 31, 2023
Member
Author
|
@st0012 we're going forward with merging these PRs, let me know later if you see some significant problem |
sl0thentr0py
added a commit
that referenced
this pull request
Aug 31, 2023
sl0thentr0py
added a commit
that referenced
this pull request
Sep 1, 2023
This PR is 1/2 to enable **Tracing without Performance**, i.e. make sure all our events are connected even if they are not Transactions. This enables use cases such as Errors / Transactions / Replays etc all being connected across services and not just Transactions. ### Summary of changes * new `PropagationContext` class that generates trace/span ids and baggage irrespective of whether there are transactions/spans active or not * this lives on the `Scope` * three new top level methods that first check the span and fallback on the scope's propagation context * `Sentry.get_traceparent` * `Sentry.get_baggage` * `Sentry.get_trace_propagation_headers` * move `dynamic_sampling_context` to `Event` from `TransactionEvent` since all events will now have this info * use the new top level helpers in `net/http` patch to set propagation headers closes #2056 also see #2089 --- This PR is 2/2 to enable Tracing without Performance, i.e. make sure all our events are connected even if they are not Transactions. ### Summary of changes * Implement new top level `Sentry.continue_trace(env, **options)` API that standardizes continuing an incoming trace from a rack env like hash. * Use this new API in rack/rails/sidekiq part of #2056 linked to #2084
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is 2/2 to enable Tracing without Performance, i.e. make sure all our events are connected even if they are not Transactions.
Summary of changes
Sentry.continue_trace(env, **options)API that standardizes continuing an incoming trace from a rack env like hash.part of #2056
linked to #2084