Add config.enable_tracing for easier performance tracing setup#2005
Add config.enable_tracing for easier performance tracing setup#2005sl0thentr0py merged 1 commit intomasterfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2005 +/- ##
=======================================
Coverage 98.56% 98.56%
=======================================
Files 157 157
Lines 10075 10105 +30
=======================================
+ Hits 9930 9960 +30
Misses 145 145
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
4fcb62f to
6cd676c
Compare
antonpirker
left a comment
There was a problem hiding this comment.
The only thing I do not get is what "sending not allowed" means, but otherwise it looks good.
st0012
left a comment
There was a problem hiding this comment.
Just some suggestions on the changelog
6cd676c to
fd7daad
Compare
|
master rails is broken :( I will fix later |
|
@sl0thentr0py After checking the error, it seems to be caused by Rails itself, see: rails/rails#47377. And there is already a PR for it: rails/rails#47409 So IMO we can wait a couple of days for the issue to be resolved upstream. |
The new optional boolean will set traces_sample_rate to 1.0 automatically if not set yet. If false, this will also disable tracing even if a sample rate or sampler is set.
fd7daad to
2bf8dca
Compare
The new optional boolean will set traces_sample_rate to 1.0
automatically if not set yet. If false, this will also disable tracing
even if a sample rate or sampler is set.
closes #1996