Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1963 +/- ##
==========================================
- Coverage 98.10% 98.04% -0.06%
==========================================
Files 158 157 -1
Lines 9847 9826 -21
==========================================
- Hits 9660 9634 -26
- Misses 187 192 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
daeb3eb to
eccba7f
Compare
3bdc053 to
8b25a7f
Compare
8b25a7f to
3dd2d49
Compare
Contributor
Author
|
@sl0thentr0py Can you help me check why danger is failing? |
Member
|
@st0012 no clue, but those logs are always present. I'll report upstream.. Not liking the danger experience so far, I'll look into something better once I'm back at work in January. |
sl0thentr0py
approved these changes
Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1931
Changes:
fakeredisdoesn't supportredis-rb 5.0+REDIS_RB_VERSIONto control installedredis-rb's version and test against bot~> 4.0and~> 5.0on CIsentry-rubyworks withredis-rb 5.0+too.