Skip to content

Support redis-rb 5.0+#1963

Merged
st0012 merged 4 commits intomasterfrom
use-real-redis-for-testing
Dec 13, 2022
Merged

Support redis-rb 5.0+#1963
st0012 merged 4 commits intomasterfrom
use-real-redis-for-testing

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Dec 11, 2022

This fixes #1931

Changes:

  • Use real Redis for testing because fakeredis doesn't support redis-rb 5.0+
  • Add REDIS_RB_VERSION to control installed redis-rb's version and test against bot ~> 4.0 and ~> 5.0 on CI
  • Make sentry-ruby works with redis-rb 5.0+ too.

@st0012 st0012 added this to the 6.0.0 milestone Dec 11, 2022
@st0012 st0012 self-assigned this Dec 11, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 11, 2022

Codecov Report

❌ Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.04%. Comparing base (52de12e) to head (3dd2d49).
⚠️ Report is 599 commits behind head on master.

Files with missing lines Patch % Lines
sentry-ruby/lib/sentry/redis.rb 68.75% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1963      +/-   ##
==========================================
- Coverage   98.10%   98.04%   -0.06%     
==========================================
  Files         158      157       -1     
  Lines        9847     9826      -21     
==========================================
- Hits         9660     9634      -26     
- Misses        187      192       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@st0012 st0012 force-pushed the use-real-redis-for-testing branch 2 times, most recently from daeb3eb to eccba7f Compare December 11, 2022 23:00
@st0012 st0012 force-pushed the use-real-redis-for-testing branch 2 times, most recently from 3bdc053 to 8b25a7f Compare December 11, 2022 23:12
@st0012 st0012 requested a review from sl0thentr0py December 11, 2022 23:15
@st0012 st0012 force-pushed the use-real-redis-for-testing branch from 8b25a7f to 3dd2d49 Compare December 12, 2022 10:09
@st0012
Copy link
Copy Markdown
Contributor Author

st0012 commented Dec 12, 2022

@sl0thentr0py Can you help me check why danger is failing?

Request failed [403]: https://api.github.com/user
Response: {
  "message": "Resource not accessible by integration",
  "documentation_url": "https://docs.github.com/rest/reference/users#get-the-authenticated-user"
}
Request failed [403]: https://api.github.com/user
Response: {
  "message": "Resource not accessible by integration",
  "documentation_url": "https://docs.github.com/rest/reference/users#get-the-authenticated-user"
}

@st0012 st0012 modified the milestones: 6.0.0, 5.8.0 Dec 12, 2022
@sl0thentr0py
Copy link
Copy Markdown
Member

@st0012 no clue, but those logs are always present. I'll report upstream..

Not liking the danger experience so far, I'll look into something better once I'm back at work in January.
For now, feel free to ignore it if it's not changelog related, we removed the required status on that check.

@st0012 st0012 merged commit dce8ef0 into master Dec 13, 2022
@st0012 st0012 deleted the use-real-redis-for-testing branch December 13, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redis instrumentation doesn't work with latest redis-rb library version

3 participants