Add exited status to SessionFlusher and rescue ThreadError#1851
Merged
Add exited status to SessionFlusher and rescue ThreadError#1851
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1851 +/- ##
==========================================
+ Coverage 98.38% 98.40% +0.01%
==========================================
Files 146 146
Lines 8744 8773 +29
==========================================
+ Hits 8603 8633 +30
+ Misses 141 140 -1
Continue to review full report at Codecov.
|
st0012
reviewed
Jul 23, 2022
st0012
approved these changes
Jul 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we are unable to create a Thread, the underlying process is probably in an aborting state, so just gracefully stop trying to do session logic.
Additionally, if we call
session_flusher.kill, we don't want to run session logic from then on.fixes #1848