Prepare for Rails 7.1's error reporter API change#1834
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1834 +/- ##
==========================================
- Coverage 98.45% 98.40% -0.05%
==========================================
Files 146 146
Lines 8667 8673 +6
==========================================
+ Hits 8533 8535 +2
- Misses 134 138 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cdf9c7a to
1875e02
Compare
This is to prevent issues like #1765 from happening again.
Contributor
Author
Co-authored-by: Jean byroot Boussier <jean.boussier+github@shopify.com>
sl0thentr0py
approved these changes
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails 7.1 will introduce a new
sourcekeyword argument toErrorReporterAPIs. So we should support that as well.Related PR: rails/rails#44998