Add config.rails.register_error_subscriber to control error reporter integration#1771
Merged
Add config.rails.register_error_subscriber to control error reporter integration#1771
Conversation
sl0thentr0py
approved these changes
Mar 21, 2022
aa0fe46 to
66ef618
Compare
66ef618 to
d1776d0
Compare
This was referenced Mar 21, 2022
kevindew
added a commit
to alphagov/govuk_app_config
that referenced
this pull request
May 11, 2022
This isn't strictly necessary as these just bump the minimum versions and this gem will still work 5.2 of these. However this seemed like a good idea to me as 5.3 provides a fix for lots of extra errors being reported when upgrading to Rails 7, which I believe we may have experienced in GOV.UK Publishing apps [1] [1]: getsentry/sentry-ruby#1771
kevindew
added a commit
to alphagov/govuk_app_config
that referenced
this pull request
May 11, 2022
This isn't strictly necessary as these just bump the minimum versions and this gem will still work 5.2 of these. However this seemed like a good idea to me as 5.3 provides a fix for lots of extra errors being reported when upgrading to Rails 7, which I believe we may have experienced in GOV.UK Publishing apps [1] [1]: getsentry/sentry-ruby#1771
kevindew
added a commit
to alphagov/govuk_app_config
that referenced
this pull request
May 11, 2022
This isn't strictly necessary as these just bump the minimum versions and this gem will still work 5.2 of these. However this seemed like a good idea to me as 5.3 provides a fix for lots of extra errors being reported when upgrading to Rails 7, which I believe we may have experienced in GOV.UK Publishing apps [1] [1]: getsentry/sentry-ruby#1771
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As explained in rails/rails#43625 (comment), we decided to make the integration disabled by default.
Closes #1731, #1754, #1765