fix: Set last_event_id only for error events#1767
Merged
sl0thentr0py merged 2 commits intomasterfrom Mar 21, 2022
Merged
Conversation
st0012
reviewed
Mar 19, 2022
| end | ||
|
|
||
| @last_event_id = event&.event_id | ||
| @last_event_id = event&.event_id unless event.is_a?(Sentry::TransactionEvent) |
Contributor
There was a problem hiding this comment.
@sl0thentr0py this is the reason I want to do the inheritance-removal refactor. they are basically 2 types of events but yet they're both Sentry::Event.
st0012
approved these changes
Mar 19, 2022
Contributor
st0012
left a comment
There was a problem hiding this comment.
can you add a changelog entry for this? thx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
last_event_idonly has a valid use case for cross-referencing errors on the end-user UI, updating it for transactions doesn't make sense and is consistent with python.Fixes #1766