Log Redis command arguments if send_default_pii = true#1726
Merged
st0012 merged 4 commits intogetsentry:masterfrom Mar 4, 2022
Merged
Log Redis command arguments if send_default_pii = true#1726st0012 merged 4 commits intogetsentry:masterfrom
st0012 merged 4 commits intogetsentry:masterfrom
Conversation
Contributor
|
@lewispb Thanks for the work! Again! The PR looks great but I need to do one or two patch releases before merging |
Contributor
Author
|
No worries at all @st0012! I just pushed a test case I missed for the span description. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1726 +/- ##
==========================================
+ Coverage 98.38% 98.40% +0.01%
==========================================
Files 141 141
Lines 8053 8079 +26
==========================================
+ Hits 7923 7950 +27
+ Misses 130 129 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
st0012
approved these changes
Mar 4, 2022
Contributor
st0012
left a comment
There was a problem hiding this comment.
Thanks again for the follow up work 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1718
Description
When config.send_default_pii = true we will also log any Redis command arguments