Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1687 +/- ##
=======================================
Coverage 98.55% 98.55%
=======================================
Files 136 136
Lines 7691 7695 +4
=======================================
+ Hits 7580 7584 +4
Misses 111 111 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sl0thentr0py
left a comment
There was a problem hiding this comment.
hmm ideally this check should be done just once in a centralized place, but I can't see a good place for it without changing too many things, so it's fine for now :)
|
@sl0thentr0py Yeah I agree with you. I think it depends on whether we expect users to initialize events themselves and call If we do, then I think the current approach (2 levels of checks) is necessary. |
|
|
Fixes #1683