Skip to content

Lock faraday to version 1.x#1664

Merged
st0012 merged 2 commits intomasterfrom
lock-farady
Jan 4, 2022
Merged

Lock faraday to version 1.x#1664
st0012 merged 2 commits intomasterfrom
lock-farady

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Jan 4, 2022

See #1663 for more information.

@st0012 st0012 added this to the 4.9.0 milestone Jan 4, 2022
@st0012 st0012 self-assigned this Jan 4, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 4, 2022

Codecov Report

Merging #1664 (3f54313) into master (7fb3092) will increase coverage by 0.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1664      +/-   ##
==========================================
+ Coverage   97.71%   98.47%   +0.75%     
==========================================
  Files          59      136      +77     
  Lines        2406     7656    +5250     
==========================================
+ Hits         2351     7539    +5188     
- Misses         55      117      +62     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/event.rb 98.87% <0.00%> (ø)
sentry-ruby/spec/sentry/linecache_spec.rb 100.00% <0.00%> (ø)
sentry-ruby/lib/sentry/interfaces/stacktrace.rb 95.55% <0.00%> (ø)
sentry-ruby/spec/sentry/breadcrumb_buffer_spec.rb 100.00% <0.00%> (ø)
sentry-ruby/lib/sentry/release_detector.rb 100.00% <0.00%> (ø)
...ntry-ruby/spec/sentry/client/event_sending_spec.rb 99.60% <0.00%> (ø)
sentry-ruby/spec/sentry/event_spec.rb 100.00% <0.00%> (ø)
sentry-ruby/lib/sentry/scope.rb 100.00% <0.00%> (ø)
sentry-ruby/lib/sentry/breadcrumb_buffer.rb 100.00% <0.00%> (ø)
...ry-ruby/spec/sentry/breadcrumb/http_logger_spec.rb 100.00% <0.00%> (ø)
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fb3092...3f54313. Read the comment docs.

@st0012
Copy link
Copy Markdown
Contributor Author

st0012 commented Jan 4, 2022

@sl0thentr0py I'll backport this to the 4-8 branch.

@st0012 st0012 merged commit 4c0be87 into master Jan 4, 2022
@st0012 st0012 deleted the lock-farady branch January 4, 2022 21:51
st0012 added a commit that referenced this pull request Jan 4, 2022
* Lock faraday to version 1.x

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants